The dual shocks (1/2/3) as actual controllers are barely tolerable. Cramped layout, loose analog sticks with large dead zones, bad d-pad, poor button feel, grips that are too short, etc. Even more annoying is the fanboyism that insists they're the best.
The controller port standard, however, is great for adapters and such, so if you have an arcade stick or something you really like, if it has a Playstation connector, you can find an adapter for just about any system.
The best actual controller is probably the Xbone controller, with the 360 a close second.